[Saskia]

Updated to v1.72 and problem persists. It is only this theme which is causing the issue. If I change to any other theme the problem goes away.

Any other suggestions?

Attachments:

You must be logged in to view attached files.

[Saskia]

Thanks Kyle.

[Saskia]

For a visual explanation, see the attached images.
In the theme options I have logo max height set to 46px, and logo padding set to 10px.
In the image ‘Header-logo-correct’ the logo is showing correctly at 46px height with 10px padding above and below, making the header a total of 66px height.
In the image ‘Header-logo-too-big’ the logo is showing at 66px height, with no padding above and below and the header is still 66px height. I think what’s happening now is it’s taking the logo max height (46px), adding the padding (10px+10px) which gives the header height of 66px, and then forcing the logo to be the same height which is not correct.

Attachments:

You must be logged in to view attached files.

[Saskia]

Oops, ok after some more snooping I don’t think that was the cause of the problem.

It seems there is another piece of code which was added since the last update which is causing the issue:

This code is newly added:

$header_height_num = str_replace( $header_height, 'px', '' );
				if ( $logo_maxheight > $header_height_num) {
					$logo_maxheight = $header_height_num;

I think that’s where it’s causing the logo to display at the same height as the header and it’s ignoring the max-height setting in the theme options. Possibly a bug?

[Saskia]

Hi Rui,

Thanks for your feedback.

Since it was only the logo which was causing the issue I decided to fix the problem myself. In the sf-header.php file there is this code:

// Standard Logo
 if ( isset( $sf_options['logo_upload'] ) ) {
     $logo = $sf_options['logo_upload'];
     }

I simply added an extra line of code to check for ssl, so it looks like:

// Standard Logo
if ( isset( $sf_options['logo_upload'] ) ) {
    $logo = $sf_options['logo_upload'];
        if (is_ssl()) { $logo = str_replace( 'http:', 'https:', $logo ); }
    }

And now it works perfectly. The checkout and account pages use SSL without problems.

[Saskia]

Brilliant, thanks Rui.

[Saskia]

If I may offer a suggestion, the action of removing items from the cart at the checkout page shouldn’t really be allowed, so maybe a solution might be to disable the cart popup on the checkout page. That way, if you need to change or remove any items you’re forced to go back to the cart page.

[Saskia]

I’ve attached a quick screencast recording which shows me removing some items from the cart with no problems, then I go to the checkout page and try to remove an item and it crashes. I’ve tested this in multiple browsers, and on various devices and it always crashes under the same situation.

Attachments:

You must be logged in to view attached files.

[Saskia]

In case it helps, here is a list of the plugins I have installed:

Wordpress 4.2.1

Breadcrumb NavXT v5.2.0
Contact Form 7 v4.1.2
Revolution Slider v4.6.9
Swift Framework v1.03
WooCommerce v2.3.8
WooCommerce Offline Credit Card Processing v1.7.0
WooCommerce Quickview v3.0.7
WooCommerce Table Rate Shipping v3.6.1
YITH WooCommerce Wishlist v2.0.6

It’s a fairly fresh install and uses minimal plugins. Also, the account and checkout pages are using HTTPS.

[Saskia]

Unfortunately I can’t give you access to the website as it’s behind a firewall and only accessible internally. I don’t think it’s a problem which is unique to my setup anyway because I’ve tried it on your live demo site and it also crashes when doing the same thing.

[Saskia]

Thanks Kyle, that’s an even better solution!

Although it didn’t actually get rid of the sidebar with that code, I tweaked it a little and it’s working perfectly now.

It worked with this code:

@media only screen and (max-width: 767px) { 
.has-left-sidebar .sidebar {
  display: none;
}
}

Thanks again for the help.

[Saskia]

Reinstalled the plugin using the recommended plugins list and all good now.

Thanks Ed!

[Saskia]

Oops, scratch that. Just set Default Show Page Heading to off and it’s working perfectly. All sorted!

[Saskia]

Ok, after a bit of snooping around I’ve found out a few things.

When you install the quickview plugin from the recommended plugins list, it downloads the latest version from your website:
http://swiftideas.com/extras/plugins/jck_woo_quickview.zip

This is the one which shows up twice in the plugins list after it’s installed and fails to work.

I found a different copy of the file which was included in the theme files:

\Atelier_v1.01\Premium Plugins\codecanyon-4378284-woocommerce-quickview-2\jck_woo_quickview.zip

Installed that one manually and it works fine.

But the files are not the same. The one included with the theme files is 107kb with modified date of 8/04/2015, and the one which is downloaded from your website is 149kb with modified date of 23/04/2015.
Also, if you look inside the zip files, the 107kb file (the working one) has only one file in the root zip folder:
jck_woo_quickview.php
Whereas, the 149kb file has two files in the root zip folder:

jck_woo_quickview (Ed Cousins's conflicted copy 2015-04-06).php
jck_woo_quickview.php

which might explain why it shows up twice in the plugins list after installation.

Any ideas why that one is not working?

[Saskia]

Sorry to report this, but I updated the theme to v1.01 today and the old products are still showing the page heading at the top. Did your change make it into this update?