Digital experiences for all disciplines
Forum Replies Created
-
-
Thanks, there are free plugins that do the job but it would be much better to have it build into cardinals framework.
September 7, 2014 at 12:04 am in reply to: Cardinal v1.7 – Mobile menu sub-menu functionality bugs #107708I think I figured the problem out.
On my demo site I had no logo uploaded, so it used my sites name as a text based header/logo.
For whatever reason that seems to cause issues in cardinal, as when I enabled the default cardinal logo that comes with the theme, the issue seems to go away…
September 6, 2014 at 10:39 pm in reply to: Cardinal v1.7 – Mobile menu sub-menu functionality bugs #107688Hey,
That issue was tested on the main site of my demo multisite installation. Havnt tested it on a single site install yet.
Edit: just doing some further testing and it’s also happening a lot on a Samsung Galaxy s4 using the chrome browser. Latest version of Android…
September 6, 2014 at 10:26 pm in reply to: How to modify 'Install Required Plugins' functionality? #107684Got it to work 🙂
I turned on wp debug as you directed and from that it indicated that I needed to include the following file in my child themes includes folder as well: class-tgm-plugin-activation.php
So for anyone else looking to do the same.
#1. Edit Cardinals functions.php file as follows on line 40:
/* include_once(SF_INCLUDES_PATH . '/plugin-includes.php'); */ include_once(get_stylesheet_directory() . '/includes/plugin-includes.php');
#2. Create an includes folder within your child theme and copy both these files into it:
plugin-includes.php
class-tgm-plugin-activation.php#3. Edit those files as desired.
So, considering what I have set up now, can you confirm that the only file I will need to continuously manually edit on theme updates is the functions.php file as out I laid out above? (there is definitely no way around this?)
Thanks.
September 6, 2014 at 10:04 pm in reply to: Cardinal v1.7 – Mobile menu sub-menu functionality bugs #107679Hey Ed,
I picked up an iPhone 4 for testing purposes. The latest version of IOS in installed and I have tested this on both safari and chrome browsers. The page reload issue (reloads to the homepage) when you click/touch the mobile menu icon is also evident on mobile browsers; so its not isolated to the desktop browser.
It happens a lot on the iPhone and makes the menu almost unusable…
That sorted it thanks.
Is that an issue only evident on my install or the theme in general.
This reply has been marked as private.September 5, 2014 at 10:52 am in reply to: Cardinal v1.7 – Mobile menu sub-menu functionality bugs #107374Yea, that sounds about right re: the page reload. Odd one.
Thanks.
September 5, 2014 at 10:51 am in reply to: How to modify 'Install Required Plugins' functionality? #107373Hi Ed,
No, unfortunately that line of code breaks the site.
Is the conclusion that I would need to edit the plugin-includes.php file in the main Cardinal folder each time (there is a theme update) and there is definitely nothing that can be done within the child theme?.
Thanks.
September 4, 2014 at 6:40 pm in reply to: How to modify 'Install Required Plugins' functionality? #107161That is no problem; but why was laranz – SUPPORT giving me directions that you are saying is not possible?
September 4, 2014 at 6:33 pm in reply to: How to modify 'Install Required Plugins' functionality? #107158That removes the error, but does not achieve what I asked above.
I want to create an altered plugin-includes.php file and place it in my child theme so that it is not overwritten on theme updates. Are you saying that is not possible and I need to directly edit that file in the main theme directory?
September 4, 2014 at 5:59 pm in reply to: How to modify 'Install Required Plugins' functionality? #107150Sorry,
Not sure what you mean. Can you explain exactly what I need to do?
Thanks.
September 4, 2014 at 11:37 am in reply to: How to modify 'Install Required Plugins' functionality? #107048This reply has been marked as private.September 4, 2014 at 11:28 am in reply to: How to modify 'Install Required Plugins' functionality? #107042Ok, thats fine.
But as I said above, the suggested change in the functions.php breaks the site…
September 4, 2014 at 10:14 am in reply to: Cardinal v1.7 – Mobile menu sub-menu functionality bugs #107003This reply has been marked as private. -