Forum Replies Created

Viewing 15 posts - 1 through 15 (of 31 total)
  • kingrobb
    Member
    Post count: 31

    OK – I just tried this. Renamed the file as well. It still comes up on the checkout page as http://…favicon.png
    and not https://

    kingrobb
    Member
    Post count: 31
    This reply has been marked as private.
    kingrobb
    Member
    Post count: 31

    I would also be interested if there is a way to change the placement for the closing so that it can come after the closing </div to the <div class=”mega-menu-widget”> that holds the images. That way the link also includes the image as its hotspot.

    
    <li class="menu-item-14278 menu-item menu-item-type-post_type menu-item-object-page default sf-std-menu sf-menu-item-html">
    <a href="http://impactmulti.staging.wpengine.com/business/flags/i-catcher-blade/">Blade
    <div class="mega-menu-widget"><img src="http://impactmulti.staging.wpengine.com/wp-content/uploads/2015/04/Blades-220x175.png" class="attachment-medium size-medium wp-post-image" alt="Blades"></div>
    </a>
    </li>
    

    Perhaps there is a function that I could put in my child theme functions.php that would re-write the output of the function that handles this?

    kingrobb
    Member
    Post count: 31
    This reply has been marked as private.
    kingrobb
    Member
    Post count: 31

    Hi Ed – you tried it locally with what versions of what Ed?

    We have it working with Neighborhood 2.1, WP 4.2.2., and woocommerce 2.3.13

    BTW – thanks for checking this.

    in reply to: WooCommerce's "Additional Variation Images" not working #196515
    kingrobb
    Member
    Post count: 31
    This reply has been marked as private.
    in reply to: WooCommerce's "Additional Variation Images" not working #196282
    kingrobb
    Member
    Post count: 31

    Yes – it is working with 2.10
    thanks.
    Robb

    kingrobb
    Member
    Post count: 31

    Hi Ed – we tried vers 3.0
    Robb

    kingrobb
    Member
    Post count: 31

    Thanks – I would appreciate that.
    We have re-instated theme vers 2.10 for compatibility for now.
    Robb

    kingrobb
    Member
    Post count: 31

    My client was using this plugin “Additional Variation Images” as well and the third party code was working. It stopped working when we updated to Neighborhood V3.0 (all we see is a huge and long blank space were the images would normally display).

    We have hired a Senior Developer, as you suggested, and I told him we should contact WC about their plugin not working as they provided the code specific to the Neighborhood Theme (but only testes w vers 2.05). His response was “It’s up to theme developers to be compatible with the WooCommerce plugins”. As usual its one developer saying its another developers issue to fix.

    I don’t know who’s task it really belongs to – but please add me to the list of people who would love to see this plugin working once again. Thank you!

    Any chance you are actually working on a fix? Would you please ask the developer?

    in reply to: IMPORTANT!! REVSLIDER UPDATE. #109746
    kingrobb
    Member
    Post count: 31

    mrjWells – thank you for that suggestion. It helped resolve the same problem I was having.

    BUT I HAVE ANOTHER PROBLEM that came up since this update….

    The API is no longer working as before (vers 4.3.1 worked fine). I have tech support thread going with ThemePunch. I have added mouseovers to my Main Menu. As users scroll over the menu options, the slideshow changes to different slides.

    But now only ever-other menu item works. I am not sure how many people use this API and if anyone else is having any problems with it. ThemePunch suggested the solution was to …

    I’d recommend using the “delegate” method for your events. Here’s an example:

    
    jQuery('body').on('mouseover', '#ID', function () {
       revapi6.revshowslide(1);
    });
    

    I was using …

    
    jQuery('#ID').mouseover(function () { 
       revapi6.revshowslide(1);
    });
    

    Anyway, this did not fix the problem.

    kingrobb
    Member
    Post count: 31

    OK – but isn’t this code likely to get overwritten next time there is a woocommerce update? They have updates every other month it seems.

    kingrobb
    Member
    Post count: 31

    Thank you for your quick reply!

    So I see the file you mentioned. I now see your line of code. But I am worried about what will happen with this change the next time I update WooCommerce (which is constantly updating). I want to assume that you simply inserted that line of code into the original file. But it does not appear that is the case. Right? I looked at your code, all of it, and I just compared it to the latest version of the WooCommerce code as it would appear before your change and the two pages of code are quit a bit different. Not just the line you changed – and aside from your version being un-minified.

    Here is the original file ….

    
    jQuery(function(a){return"undefined"==typeof wc_single_product_params?!1:(a(".woocommerce-tabs .panel").hide(),a(".woocommerce-tabs ul.tabs li a").click(function(){var b=a(this),c=b.closest(".woocommerce-tabs");return a("ul.tabs li",c).removeClass("active"),a("div.panel",c).hide(),a("div"+b.attr("href"),c).show(),b.parent().addClass("active"),!1}),a(".woocommerce-tabs").each(function(){var b=window.location.hash,c=window.location.href,d=a(this);b.toLowerCase().indexOf("comment-")>=0?a("ul.tabs li.reviews_tab a",d).click():c.indexOf("comment-page-")>0||c.indexOf("cpage=")>0?a("ul.tabs li.reviews_tab a",a(this)).click():a("ul.tabs li:first a",d).click()}),a("a.woocommerce-review-link").click(function(){return a(".reviews_tab a").click(),!0}),a("#rating").hide().before('<p class="stars"><span><a class="star-1" href="#">1</a><a class="star-2" href="#">2</a><a class="star-3" href="#">3</a><a class="star-4" href="#">4</a><a class="star-5" href="#">5</a></span></p>'),a("body").on("click","#respond p.stars a",function(){var b=a(this),c=a(this).closest("#respond").find("#rating");return c.val(b.text()),b.siblings("a").removeClass("active"),b.addClass("active"),!1}).on("click","#respond #submit",function(){var b=a(this).closest("#respond").find("#rating"),c=b.val();return b.size()>0&&!c&&"yes"===wc_single_product_params.review_rating_required?(alert(wc_single_product_params.i18n_required_rating_text),!1):void 0}),void a("form.cart").submit(function(){a(this).find(":submit").attr("disabled","disabled")}))});
    

    And your version …

    
    jQuery( function( $ ) {
    
    	// wc_single_product_params is required to continue, ensure the object exists
    	if ( typeof wc_single_product_params === 'undefined' ) {
    		return false;
    	}
    
    	// Tabs
    	$( '.woocommerce-tabs .panel' ).hide();
    
    	$( '.woocommerce-tabs ul.tabs li a' ).click( function(e) { e.preventDefault();
    
    		var $tab = $( this ),
    			$tabs_wrapper = $tab.closest( '.woocommerce-tabs' );
    
    		$( 'ul.tabs li', $tabs_wrapper ).removeClass( 'active' );
    		$( 'div.panel', $tabs_wrapper ).hide();
    		var show_id = $(this).attr('href').substring($(this).attr('href').indexOf('#'));
    		
    		$( 'div' +  show_id, $tabs_wrapper).show();
    		$tab.parent().addClass( 'active' );
    
    		return false;
    	});
    
    	$( '.woocommerce-tabs' ).each( function() {
    		var hash	= window.location.hash,
    			url		= window.location.href,
    			tabs	= $( this );
    
    		if ( hash.toLowerCase().indexOf( "comment-" ) >= 0 ) {
    			$('ul.tabs li.reviews_tab a', tabs ).click();
    
    		} else if ( url.indexOf( "comment-page-" ) > 0 || url.indexOf( "cpage=" ) > 0 ) {
    			$( 'ul.tabs li.reviews_tab a', $( this ) ).click();
    
    		} else {
    			$( 'ul.tabs li:first a', tabs ).click();
    		}
    	});
    
    	$( 'a.woocommerce-review-link' ).click( function() {
    		$( '.reviews_tab a' ).click();
    		return true;
    	});
    
    	// Star ratings for comments
    	$( '#rating' ).hide().before( '<p class="stars"><span><a class="star-1" href="#">1</a><a class="star-2" href="#">2</a><a class="star-3" href="#">3</a><a class="star-4" href="#">4</a><a class="star-5" href="#">5</a></span></p>' );
    
    	$( 'body' )
    		.on( 'click', '#respond p.stars a', function() {
    			var $star   = $( this ),
    				$rating = $( this ).closest( '#respond' ).find( '#rating' );
    
    			$rating.val( $star.text() );
    			$star.siblings( 'a' ).removeClass( 'active' );
    			$star.addClass( 'active' );
    
    			return false;
    		})
    		.on( 'click', '#respond #submit', function() {
    			var $rating = $( this ).closest( '#respond' ).find( '#rating' ),
    				rating  = $rating.val();
    
    			if ( $rating.size() > 0 && ! rating && wc_single_product_params.review_rating_required === 'yes' ) {
    				alert( wc_single_product_params.i18n_required_rating_text );
    
    				return false;
    			}
    		});
    
    	// prevent double form submission
    	$( 'form.cart' ).submit( function() {
    		$( this ).find( ':submit' ).attr( 'disabled','disabled' );
    	});
    });
    

    So would I re-do this change next time woocommerce updates?

    Robb

    kingrobb
    Member
    Post count: 31

    That is awesome Mohammad – thank you very much (excellent support)!!!

    I want to be able to redo your edit in the event that it gets overwritten with a future update – BUT I am unclear as to what you actually did. I have looked at the file …

    plugins\woocommerce\assets\js\frontend\single-product.js

    … and I can not see the line of code you mentioned. I looked at an older version of this file and can not see that code there either (in the event that you simply removed that line). So I am confused as to what you did, where and how can re-do it again in the future.

    Cheers – and many thanks.

    Robb

    kingrobb
    Member
    Post count: 31
    This reply has been marked as private.
Viewing 15 posts - 1 through 15 (of 31 total)