Digital experiences for all disciplines
New Landing › How can we help? › Cardinal › Site gone weird after update…
New Landing › How can we help? › Cardinal › Site gone weird after update…
- This topic has 75 replies, 12 voices, and was last updated 8 years by Swift Ideas – Ed.
-
Posted in: Cardinal
-
October 19, 2016 at 9:33 am #297371
Hi @manofmany
EDIT: Ignore previous message. For some reason looks like you are missing a class around the page content. Can you provide a login to your site for us to investigate?
– Ed
October 19, 2016 at 11:32 am #297405This reply has been marked as private.October 19, 2016 at 12:48 pm #297432Hi @manofmany
You had one of the changed swift framework files overridden in your child theme. This was the issue. I updated that for you, and all sorted now.
– Ed
October 19, 2016 at 1:24 pm #297447@WEswift – so am I correct in saying that the rows are missing the overlay colour over the background (parallax) image?
It doesn’t seem as if you have any full width issues anymore – is that correct?
– Ed
October 19, 2016 at 4:24 pm #297496Ed – It would be most accurate to say the background color is missing BELOW the parallax image.
After some investigation, it seems the issues are the css width settings on and placement in the html hierarchy of div.container. All of it’s contents (including div.spb-row) do extend to the edges of div.container. I think the div.container width is getting set in Theme Options > General Options > Site Width (1170 is default). It’s no longer being overridden by the Page Layout > Full Width setting that follows.
As for its location in the page container hierarchy, I’ve noticed a big difference between my example site and http://cardinal.swiftideas.com/. On that demo Cardinal site, the div.container is much farther down in the html container hierarchy (see attached cardinal-example.png). In my site, div.container is a direct child of div#main-container. I’ve also noticed a difference with that example site’s css. There is a max-width 100% setting that the current Cardinal theme doesn’t seem to use.
Thoughts?
-PaulAttachments:
You must be logged in to view attached files.October 20, 2016 at 12:45 am #297578Hi Ed,
Thanks for looking into it for us. Could you please let us know exactly what you did as now some of the images aren’t showing as Full Width even though that’s what’s been set in Swift Page Builder.
As per the post below, the large images are meant to stretch across the whole window (i.e. “Full width”) while the other sections should remain within the 1050px width.
http://manofmany.com/featured/fathers-day-gift-guide-2016
Are you able to let me know what exactly you changed in our Child theme so we’re across it?
Appreciate your help as we need this urgently fixed for a sponsored post on the website.
Kind regards,
ScottOctober 20, 2016 at 1:28 am #297581Appreciate your help on this and thanks for your patience Ed.
October 20, 2016 at 6:18 am #297592Hi @manofmany
We are shortly releasing a fix for the images (to the plugin), and we only changed /swift-framework/layout/single-post.php
Thanks,
– Ed
October 20, 2016 at 7:12 am #297594@WEswift – that is intended. The reason being so is that we are prepping for the future, and the potential of a standalone builder which could be used outside of our themes. We have setup in place to be able to allow the rows and elements to go edge to edge however.
I’m still not sure what you are trying to do with the row in regards to the image layer “being above” the background colour. Apologies for my confusion. If you are looking to overlay a colour over the image then there is the “row overlay” option where you can set a colour and an opacity. If i’m missing something, please try to explain a little further – thanks.
– Ed
October 20, 2016 at 3:54 pm #297739Ed – To quote you: “We have setup in place to be able to allow the rows and elements to go edge to edge however.” What does that statement mean? Is this simply restating what I previously discovered / mentioned? Or are you suggesting there’s a fix in the works? The rows should be able to visually extend to the edges of the browser window.
A further clarification of the parallax layering scheme: the lowest layer – let’s call it the Base Layer (z-index: 0) has a background color applied. The layer on top of that – let’s call it the Image Layer (z-index: 1) contains a png image with transparency. With this layer order, the background color of the Base Layer below can be seen below / through the Image Layer. The theme upgrade essentially removed the background color of the Base Layer.
Please provide a ballpark timeline of when fixes might be available. Thanks in advance.
-Paulps – I’m using the latest Swift Framework version 2.5.18 and the above two issues are still present.
October 20, 2016 at 4:17 pm #297746@WEswift – apologies for any confusion. I was stating that this is the intended functionality / placement of the “container” div. When making this change we added some backwards compatibility setup in order to convert legacy rows, until the page or that row was updated. Now when you edit a row, you will find various options for the layout such as standard, full width contained, and full width stretched. Standard is container width, Full width contained makes the background full width but the content contained, and finally full width stretched makes the background and contents stretched. It looks as if the legacy conversion is no longer in place because of an edit to that row, so please can you edit the row to see what you have set here – and adjust accordingly?
Thanks for the clarification of that background image setup, have fixed that for the next update. You can add this css now:
.spb-row-parallax .spb-row-parallax-layer-wrap { background: transparent; }
– Ed
October 20, 2016 at 4:47 pm #297771Ed – I had previously edited all rows and applied Full Width Contained – but this does not work. Please see the attached screenshot. Please advise.
Thanks for the parallax fix. That worked.
-Paul
Attachments:
You must be logged in to view attached files.October 20, 2016 at 11:20 pm #297866October 21, 2016 at 4:05 pm #298038Ed – that’s the correct page but not what I see at all. Additionally some regular parallax images are missing (and at least one that is missing in the screenshot behind The Early Years content is not missing on the live page). See the attached screenshot. One actual missing parallax image should be in the big white gap between The History and the paragraph starting with a Drop Cap “Black-owned banking institutions…”
I had my brother send me a screenshot and he got the same result as I did – with rows not extending the entire window width.
Thoughts?
-PaulAttachments:
You must be logged in to view attached files.October 22, 2016 at 1:29 am #298112Hi Paul,
Just to confirm that this is the link I’m meant to be looking at? – http://bit.ly/2dZhJof
Attached is what I see. I’m unable to replicate what you see. Is it a certain browser by any chance?
– Ed
Attachments:
You must be logged in to view attached files. -
Posted in: Cardinal
You must be logged in and have valid license to reply to this topic.