possible bug with tabs and id="xxx"

[juliewaterhouse]

I’ve run into an odd problem when using tabs when I have another shortcode (from another plugin) inside then that uses id=”xx”.

My problem started after upgrading to the latest version of the theme. Tabs stopped working (click and nothing happens). I switched over to the classic view to see what was happening behind the scenes. After some investigation and experimenting, I discovered the following.

Working Scenario (edited for simplicity):

[spb_tabs width="1/1" el_position="first last"] [spb_tab title="Getting Started" icon="" id="gettingstarted"] [spb_text_block pb_margin_bottom="no" pb_border_bottom="no" el_class="highlight-box" width="1/1" el_position="first last"]
stuff
[/spb_text_block] 
[/spb_tab] 
[spb_tab title="Week 1" icon="" id="week1"] [spb_text_block pb_margin_bottom="no" pb_border_bottom="no" el_class="highlight-box" width="1/1" el_position="first last"]
more stuff
[/spb_text_block] 
[/spb_tab]
[spb_tab title="Week 2” icon="" id="week2”] [spb_text_block pb_margin_bottom="no" pb_border_bottom="no" el_class="highlight-box" width="1/1" el_position="first last"]
more stuff
[/spb_text_block] 
[/spb_tab]
[/spb_tabs]

Broken Scenario:

[spb_tabs width="1/1" el_position="first last"] [spb_tab title="Getting Started" icon="" id="gettingstarted"] [spb_text_block pb_margin_bottom="no" pb_border_bottom="no" el_class="highlight-box" width="1/1" el_position="first last"]
stuff
[/spb_text_block] 
[/spb_tab] 
[spb_tab title="Week 1" icon="" id="week1"] [spb_text_block pb_margin_bottom="no" pb_border_bottom="no" el_class="highlight-box" width="1/1" el_position="first last"]
[download template="custom-button" id="413"]
[/spb_text_block] 
[/spb_tab]
[spb_tab title="Week 2” icon="" id="week2”] [spb_text_block pb_margin_bottom="no" pb_border_bottom="no" el_class="highlight-box" width="1/1" el_position="first last"]
more stuff
[/spb_text_block] 
[/spb_tab]
[/spb_tabs]

The key difference is that as soon as I introduce the shortcode [download template=”custom-button” id=”413″], which contains an id=”something” inside the shortcode brackets, the tabs get messed up. In this scenario, where I’ve placed the shortcode inside the week1 tab (currently like this on the site), you can see that the link for the first tab is correct:
http://programs.biancaschaefer.com/love-your-body-again-fitness-program/#gettingstarted

but the Week1 tab is no longer http://programs.biancaschaefer.com/love-your-body-again-fitness-program/#week1. Instead it picks up the id from the download shortcode:
http://programs.biancaschaefer.com/love-your-body-again-fitness-program/#413

The week2 tab then gets the week1 id, and everything is shifted.

It looks like possibly your code is looking for the next occurrence of id=”xx” inside a [ ] in order to grab the id/link for the next tab. However in this case, there’s another shortcode interfering.

Page where this is happening:
Note: this is protected content on a membership site, so you’ll have to log in to view.
http://programs.biancaschaefer.com/love-your-body-again-fitness-program/
On this page, I’ve removed all but one of the download shortcodes.

On the following (almost identical) page, all the download shortcodes are still there. This is how the page appeared right after plugin upgrade. Here, there are no ids at all for the tabs (and there weren’t on the first page when I started; I added them into the code myself on the above page to try to get things working), but there are unique links created for each one — but again, the ids from the downloads are interfering.
http://programs.biancaschaefer.com/the-love-your-body-again-fitness-program-no-bonus/

The plugin that’s creating the shortcodes is Download Monitor. I suspect this would be an issue with any shortcode that has id=”” inside it though.

[Rui Guerreiro – SUPPORT]

Hi,

There was a bug in the Tabs id in the last version.
Can you try this one? We will release it officially in the next days.

https://www.dropbox.com/s/qic8ojpdca89apz/dante.zip?dl=0

-Rui

[juliewaterhouse]

I tried the new theme version. No change to the behaviour.

[Rui Guerreiro – SUPPORT]

Hi,

Did you cleared the browser cache?
Can you send me the link for the page? The other link isn’t working anymore.

-Rui

[juliewaterhouse]

Yes, I tried in a completely different browser to make sure it wasn’t cached.

What do you mean by the link “not working?” You do have to be logged in first, as it’s a member-only protected page. I just tried, and the links are working for me.

The link should be:
http://programs.biancaschaefer.com/love-your-body-again-fitness-program/
or
http://programs.biancaschaefer.com/the-love-your-body-again-fitness-program-no-bonus/

Thanks!

~Julie

[David Martin – Support]

Hi Julie,

The latest version of Dante fixes the tabs not working. The previous version, the tabs broke. Please run the update in your WP dashboard.

Thanks.

[juliewaterhouse]

Thank you. The latest version worked.

[Rui Guerreiro – SUPPORT]

Glad it’s sorted.

-Rui

[juliewaterhouse]

Sorry, I spoke too soon. Because I had updated to the version suggested in the support thread (https://www.dropbox.com/s/qic8ojpdca89apz/dante.zip?dl=0), I didn’t see any updates available in the Dashboard, so I grabbed the one from the Envato marketplace. That was only v3.3.32, however. I tested with that, and it worked fine. That’s when I reported that everything looked good.

However, I then saw there was an update available through WP to v3.3.41. When I updated to that, my tabs broke again.

I gave a pretty specific description of what was happening earlier in thread when I first opened it.

(I’m now at WP 4.7.4)

[Rui Guerreiro – SUPPORT]

Can you try this one? This already includes a latest fix with the tabs.
https://www.dropbox.com/s/6l5hq3ybqptis00/dante%202.zip?dl=0

-Rui

[juliewaterhouse]

It’s the same version number (Version: 3.3.41) as the one I downloaded through the WP Dashboard. And unfortunately, it doesn’t work.

Is it possible that the problem with tabs that you just fixed doesn’t address the issue I’m having? Could you take a closer look at the details, and see whether you think your current code should work with the rather unusual scenario I describe? I’ve tried three different versions now, all that you say have your tabs fix in, but none of them has addressed this particular case.

v 3.3.32 does work. Did your fix in the tabs area revert back to the same code as 3.3.32, or were there additional changes that could have broken this quite specific use case?

Thanks!

[Rui Guerreiro – SUPPORT]

It’s the same number version but it has different code. I was thinking that this was the ids issue we fixed.

But this is different, it’s a conflict because of the id parameter that you have in the download shortcodes, it’s grabbing the id of the download.

Will need to check this again with the dev team.

-Rui

[juliewaterhouse]

Could I get an update, please? I have a client holding off on a launch until this is fixed. FYI, I have tried with the new 3.3.42, and it’s still not working.

Thanks.

[Rui Guerreiro – SUPPORT]

Do you have too many pages where it’s happening? I can fix the ids directly in the classic editor mode, we just can’t change them in the page builder or it will pick the download id.

This is only to sort it temporarily until we have a code solution. We have been pretty busy with all the work around the Woocommerce updates and couldn’t start this fix yet.

-Rui

[Rui Guerreiro – SUPPORT]

I think I found a solution, can you copy the file below to dante/swift-framework/page-builder/builder/shortcodes
https://www.dropbox.com/s/23vrnvpvcmbveqt/tabs.php?dl=0

If your content already has the incorrect ids from the download shortcode, then you need to edit and save the tab title and after that update the page so the ids are correctly assigned again.
I made a screencast:
https://www.dropbox.com/s/p72g6vr17z0xypb/Screen%20Capture%20on%202017-04-27%20at%2016-34-46.gif?dl=0

-Rui