New Landing How can we help? Themeforest Theme Support Neighborhood A few issues after updating a few times

Viewing 15 posts - 16 through 30 (of 40 total)
  • #214548
    MarcusRG
    Member
    Post count: 69

    Hi

    It works with parent theme.

    So I don’t get why it didn’t work when replacing php files from child theme?

    #214556
    MarcusRG
    Member
    Post count: 69

    Okay, I checked the differ: https://www.diffchecker.com/ajqsv0tx

    Our archive has a few changes – for example our category description under products instead of above. But I can’t seem to find this here.

    What I do seem to find is that the h1 asset + breacrumb area is removed in the newest version.

    #214559
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    Well now it will be necessary to copy the changes across, or copy the entire file from the parent theme and apply again the changes you made in the child theme.

    What’s that file name?

    -Rui

    #214579
    MarcusRG
    Member
    Post count: 69

    The only files in my child themes are

    archive-product.php
    content-prduct.php
    content-single-product.php

    And all of the versions are 1.0.. so yeah, they’re pretty outdated.

    So what’s the purpose of having child theme if they’re outdated as soon as you guys update your theme?

    #214584
    David Martin – Support
    Moderator
    Post count: 20834

    Hi Marcus,

    In most cases everything is ok, however recently WooCommerce released a large update and we also also improved our code structure which means the files need updating.

    Thanks,
    David.

    #214585
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    well using a child theme is the best practice to avoid lose changes but it’s not 100% update proof because of this situations when the files that are updated are the same in the child theme.

    In WordPress development there is no possible workaround for this situation(except don’t create new versions of the parent theme).

    -Rui

    #214657
    MarcusRG
    Member
    Post count: 69

    Is this something you guys can do? I’m not really that good with code.

    I only think it’s about those 3 files (at least they’re the only ones in my child theme)

    #214944
    David Martin – Support
    Moderator
    Post count: 20834

    Unfortunately not, the developer who originally did this for made some specific customisations for your requirements.

    You will need to find out what he did for you or what you asked him for. If you do not know what modifications he did, you can deactivate the child theme and compare the products pages.

    Thanks,
    David.

    #215081
    MarcusRG
    Member
    Post count: 69

    Hi David

    I know what he did. I just don’t know where to find it in the code. 🙂

    #215326
    David Martin – Support
    Moderator
    Post count: 20834

    Ok, the diff tool should be able to highlight the changes. You will then need to narrow those down to the few changes he did.

    Thanks,
    David

    #215429
    MarcusRG
    Member
    Post count: 69

    Yeah it will show the changes, but you pretty much edited the entire php file since version 1.0 from our childtheme.

    Do you handle edits on hourly pay basis?

    #215498
    David Martin – Support
    Moderator
    Post count: 20834

    Hey,

    We do not take on theme modification, our partners WerkPress handle this for us. You can work with directly: http://www.swiftideas.com/customization/.

    Thanks,
    David.

    #215534
    MarcusRG
    Member
    Post count: 69

    Okay thanks.

    Took a look at the php files again.

    In product-archive.php you removed this part:

     <?php if ( apply_filters( 'woocommerce_show_page_title', true )  && $default_show_page_heading) : ?>
        
        <div class="row">
            <div class="page-heading span12 clearfix alt-bg <?php echo $default_page_heading_bg_alt; ?>">
                <div class="heading-text">
                    
                    <?php if ( version_compare( WOOCOMMERCE_VERSION, "2.0.0" ) >= 0 ) { ?>
                        
                        <h1><?php woocommerce_page_title(); ?></h1>
                            
                    <?php } else {
                    
                        if ( is_search() ) {
                                
                            echo '<h1>';
                                    
                            printf( __( 'Search Results: &ldquo;%s&rdquo;', 'woocommerce' ), get_search_query() );
                            
                            if ( get_query_var( 'paged' ) ) {
                                printf( __( '&nbsp;&ndash; Page %s', 'woocommerce' ), get_query_var( 'paged' ) );
                            }
                            
                            echo '</h1>';
                                
                        } elseif ( is_tax() ) {
                            
                            echo '<h1>' . single_term_title( "", false ) . '</h1>';
                        
                        } else {
                            
                            $shop_page = get_post( woocommerce_get_page_id( 'shop' ) );
                            
                            echo '<h1>';
                            
                            echo apply_filters( 'the_title', ( $shop_page_title = get_option( 'woocommerce_shop_page_title' ) ) ? $shop_page_title : $shop_page->post_title );
                            
                            echo '</h1>';
                        }
                                                        
                    } ?>
                </div>
                <?php 
                    // BREADCRUMBS
                    echo sf_breadcrumbs();
                ?>
            </div>
        </div>
     
        <?php endif; ?>

    How come? When I update the PHP file, my asset heading with H1 and breadcrumb will disappear

    #215822
    David Martin – Support
    Moderator
    Post count: 20834

    Hi,

    We moved that out, it is now controlled by sf_page_heading() within /includes/swift-framework/sf-content-display/sf-page-heading.php.

    Thanks,
    David.

    #216012
    MarcusRG
    Member
    Post count: 69

    Okay great.

    Does that mean I have to include the sf-page-heading.php in my child theme as well for it to work?

Viewing 15 posts - 16 through 30 (of 40 total)

You must be logged in and have valid license to reply to this topic.

License required for the following item
Login and Registration Log in · Register