Digital experiences for all disciplines
New Landing › How can we help? › Themeforest Theme Support › Neighborhood › A few issues after updating a few times
New Landing › How can we help? › Themeforest Theme Support › Neighborhood › A few issues after updating a few times
- This topic has 39 replies, 3 voices, and was last updated 9 years by Rui Guerreiro – SUPPORT.
-
Posted in: Neighborhood
-
September 18, 2015 at 3:30 pm #214548
Hi
It works with parent theme.
So I don’t get why it didn’t work when replacing php files from child theme?
September 18, 2015 at 3:38 pm #214556Okay, I checked the differ: https://www.diffchecker.com/ajqsv0tx
Our archive has a few changes – for example our category description under products instead of above. But I can’t seem to find this here.
What I do seem to find is that the h1 asset + breacrumb area is removed in the newest version.
September 18, 2015 at 3:51 pm #214559Well now it will be necessary to copy the changes across, or copy the entire file from the parent theme and apply again the changes you made in the child theme.
What’s that file name?
-Rui
September 18, 2015 at 4:49 pm #214579The only files in my child themes are
archive-product.php
content-prduct.php
content-single-product.phpAnd all of the versions are 1.0.. so yeah, they’re pretty outdated.
So what’s the purpose of having child theme if they’re outdated as soon as you guys update your theme?
September 18, 2015 at 4:54 pm #214584Hi Marcus,
In most cases everything is ok, however recently WooCommerce released a large update and we also also improved our code structure which means the files need updating.
Thanks,
David.September 18, 2015 at 4:55 pm #214585well using a child theme is the best practice to avoid lose changes but it’s not 100% update proof because of this situations when the files that are updated are the same in the child theme.
In WordPress development there is no possible workaround for this situation(except don’t create new versions of the parent theme).
-Rui
September 18, 2015 at 8:09 pm #214657Is this something you guys can do? I’m not really that good with code.
I only think it’s about those 3 files (at least they’re the only ones in my child theme)
September 21, 2015 at 11:34 am #214944Unfortunately not, the developer who originally did this for made some specific customisations for your requirements.
You will need to find out what he did for you or what you asked him for. If you do not know what modifications he did, you can deactivate the child theme and compare the products pages.
Thanks,
David.September 21, 2015 at 3:05 pm #215081Hi David
I know what he did. I just don’t know where to find it in the code. 🙂
September 22, 2015 at 11:31 am #215326Ok, the diff tool should be able to highlight the changes. You will then need to narrow those down to the few changes he did.
Thanks,
DavidSeptember 22, 2015 at 3:41 pm #215429Yeah it will show the changes, but you pretty much edited the entire php file since version 1.0 from our childtheme.
Do you handle edits on hourly pay basis?
September 22, 2015 at 5:51 pm #215498Hey,
We do not take on theme modification, our partners WerkPress handle this for us. You can work with directly: http://www.swiftideas.com/customization/.
Thanks,
David.September 22, 2015 at 8:25 pm #215534Okay thanks.
Took a look at the php files again.
In product-archive.php you removed this part:
<?php if ( apply_filters( 'woocommerce_show_page_title', true ) && $default_show_page_heading) : ?> <div class="row"> <div class="page-heading span12 clearfix alt-bg <?php echo $default_page_heading_bg_alt; ?>"> <div class="heading-text"> <?php if ( version_compare( WOOCOMMERCE_VERSION, "2.0.0" ) >= 0 ) { ?> <h1><?php woocommerce_page_title(); ?></h1> <?php } else { if ( is_search() ) { echo '<h1>'; printf( __( 'Search Results: “%s”', 'woocommerce' ), get_search_query() ); if ( get_query_var( 'paged' ) ) { printf( __( ' – Page %s', 'woocommerce' ), get_query_var( 'paged' ) ); } echo '</h1>'; } elseif ( is_tax() ) { echo '<h1>' . single_term_title( "", false ) . '</h1>'; } else { $shop_page = get_post( woocommerce_get_page_id( 'shop' ) ); echo '<h1>'; echo apply_filters( 'the_title', ( $shop_page_title = get_option( 'woocommerce_shop_page_title' ) ) ? $shop_page_title : $shop_page->post_title ); echo '</h1>'; } } ?> </div> <?php // BREADCRUMBS echo sf_breadcrumbs(); ?> </div> </div> <?php endif; ?>
How come? When I update the PHP file, my asset heading with H1 and breadcrumb will disappear
September 23, 2015 at 3:58 pm #215822Hi,
We moved that out, it is now controlled by
sf_page_heading()
within/includes/swift-framework/sf-content-display/sf-page-heading.php
.Thanks,
David.September 24, 2015 at 9:33 am #216012Okay great.
Does that mean I have to include the sf-page-heading.php in my child theme as well for it to work?
-
Posted in: Neighborhood
You must be logged in and have valid license to reply to this topic.