New Landing › How can we help? › Themeforest Theme Support › Uplift › Product frontend error.

Viewing 11 posts - 1 through 11 (of 11 total)
  • Back to forum
    Posted in: Uplift
  • June 28, 2017 at 3:04 pm #330379
    nosuchagency
    Member
    Post count: 226

    Hi guys.

    Experiencing a very very long ‘gap’ on all productpages.
    How to get rid of the excessive space?

    Screenshot attached.

    BR.

    SorenJ.

    Attachments:
    You must be logged in to view attached files.
    June 28, 2017 at 3:31 pm #330388
    David Martin – Support
    Moderator
    Post count: 20834

    Hi,

    It seems the WooCommerce slider height is not being calculated correctly by our JS.

    This is likely due to the slider content not being 100% loaded in time for our jQuery outerHeight check to perform the correct height calculation on the slider.

    Ed is on holiday this week but is also working intermittently, I’ll assist you as much as possible before Ed is online.

    To resolve this we should be able to use the setTimeout to add a tiny ms delay to our code to allow the slider to initiate fully.

    To help you out with this, I’d like to ask you replace the /js/functions.js with my development testing file: https://gist.github.com/webadelic/f2050d0440ce48320b26a791eea36d95 this should resolve this issue – for me it does successfully. – You will need to disable the Performance Options in the Theme Options and likely clear your browser cache to test this correctly.

    If that resolves the issue for you, I’ll get a patch submitted to Ed for further review and inclusion in a future update.

    Thanks.

    June 30, 2017 at 10:30 am #330615
    David Martin – Support
    Moderator
    Post count: 20834

    Hi,

    Could you please let me know if this resolved the issue for you?

    Thanks.

    July 3, 2017 at 3:36 pm #330837
    David Martin – Support
    Moderator
    Post count: 20834

    Closing the ticket.

    Marking as resolved.

    – David.

    July 4, 2017 at 12:39 pm #330922
    nosuchagency
    Member
    Post count: 226

    Hi David.

    The script seems to work, but the theme kept loading functions.min.js even though we disabled it in the framework settings, so there might be a bug… we just called your script for functions.min.js to test it.

    Please advise.

    July 4, 2017 at 12:41 pm #330923
    nosuchagency
    Member
    Post count: 226

    PS.
    Changed topic status to “not resolved”.

    July 4, 2017 at 12:41 pm #330924
    David Martin – Support
    Moderator
    Post count: 20834

    Hi,

    Do you mind me logging in and taking a look at the options setup – enabling/disabling?

    – Are you using any plugins to cache/minify the frontend?

    Cheers.

    July 4, 2017 at 12:43 pm #330925
    nosuchagency
    Member
    Post count: 226

    Whe’re not utilising any caching plugins for now (we will utilise WP Rocket at some point).
    And yes, you’re welcome to login and have a look.

    SJ.

    July 5, 2017 at 9:58 am #330988
    David Martin – Support
    Moderator
    Post count: 20834

    Hi Soren,

    I can switch between funtions.js and function-min.js seamlessly using the Performance On/Off options. The option worked as expected both on your site and my dev site.

    When Ed sends out the update, the change will be in the minified JS file so there will not be a need to have it set to Off.

    There are no changes or related changes to this on our Git diff’s either.

    Thanks.

    July 5, 2017 at 11:17 am #331000
    nosuchagency
    Member
    Post count: 226

    Hi David.
    Great, thank you.

    I’ll mark this as resolved.

    Stay healthy :o)

    July 5, 2017 at 11:45 am #331005
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    Cool. Thanks David.

    -Rui

  • Back to forum
    Posted in: Uplift
Viewing 11 posts - 1 through 11 (of 11 total)

You must be logged in to reply to this topic.