Delete target="_blank" in Clients (Featured) – Page 2

swiftideas

ATTENTION, PLEASE READ: New topic creation is disabled, as we have moved to a new support system. Your existing topics will remain, but for all new requests you will need to use the new system. Click here to go to the new support request form.

This topic has 21 replies, 3 voices, and was last updated 6 years by David Martin – Support.

Viewing 7 posts - 16 through 22 (of 22 total)

← 1 2

Back to forum

Posted in: Dante
June 7, 2017 at 11:19 am #327369

Rui Guerreiro – SUPPORT
Keymaster

Post count: 25779

You need to remove that semicolon.

-Rui

June 7, 2017 at 11:51 am #327377

Pikay
Member

Post count: 48

Line 329 is now
$items .= '<a href="'.$client_link_url.'" "'.$target = apply_filters('sf_clients_link_target', '_blank').'"><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';

By clicking a client the link opens in the same window/tab although there is a target="_blank" tag in the source-code … magic 😀

That’s all for now?

June 7, 2017 at 11:54 am #327379

Rui Guerreiro – SUPPORT
Keymaster

Post count: 25779

If it’s working, let it be like so that in the next update David code will replace it and you will be able to choose in that option if it opens in a new window or not.

-Rui

June 7, 2017 at 12:53 pm #327397

Pikay
Member

Post count: 48

OK, thank you guys! 🙂

June 7, 2017 at 12:55 pm #327398

Rui Guerreiro – SUPPORT
Keymaster

Post count: 25779

No problem.

-Rui

June 13, 2017 at 12:26 pm #328408

Pikay
Member

Post count: 48

downloaded dante_4.8 now and the issue is still there 🙁

June 13, 2017 at 1:01 pm #328417

David Martin – Support
Moderator

Post count: 20834

Hi,

I have just submitted the patch to actually fix the bug. You will now be able to use the correct option to control the same/new window.

Next update will be out soon.

Thanks.
Back to forum

Posted in: Dante