New Landing How can we help? Themeforest Theme Support Dante Delete target="_blank" in Clients (Featured)

Viewing 15 posts - 1 through 15 (of 22 total)
  • Posted in: Dante
  • #326818
    Pikay
    Member
    Post count: 48

    Hi.

    I would like to delete the -> target=”_blank” <- attribute for the Clients (feautured) box via Page-Builder.

    The check-box while adding a client “Link to same window: Check this box to set the client link to open in the same browser window/tab.” has no function.

    T think, it is line 325 at /dante/swift-framework/page-builder/builder/shortcodes/clients.php
    $items .= '<a href="'.$client_link_url.'" target="_blank"><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';

    I could delete the target=”_blank” manually but it will work only until the next Theme-Update.

    Do you have any solutions, maybe with the functions.php?

    #327116
    David Martin – Support
    Moderator
    Post count: 20834

    Hi,

    I’ve just sorted a patch to allow you to correctly override this.

    It changes

    This:

    $target = "_blank";

    To this:

    $target = apply_filters('sf_clients_link_target', '_blank');

    You can then modify the filter via a custom function from with your child theme.

    I can add this to your site for you if you add your FTP details and active your child theme.

    Thanks.

    #327337
    Pikay
    Member
    Post count: 48

    Hi David.

    Can I add this function to the child theme by myself? Sure, If it’s too complicated, I add my FTP details.
    But I would like to try by myself with regard to the future and similiar issues.

    What do I have to do? 🙂

    Thx.

    #327340
    David Martin – Support
    Moderator
    Post count: 20834

    First of all the Page Builder code needs editing. So in: /dante/swift-framework/page-builder/builder/shortcodes/clients.php

    Chaneg this:

    $target = “_blank”;

    To this:

    $target = apply_filters('sf_clients_link_target', '_blank');

    Then you can write a new function to return a new value to the filter in your child theme functions.php file.

    #327344
    Pikay
    Member
    Post count: 48

    What about the changes in /dante/swift-framework/page-builder/builder/shortcodes/clients.php and future updates of the (parent)theme? Do I have to edit the file after every update or does the filter in the child-theme functions.php prevent an overwrite?

    #327346
    David Martin – Support
    Moderator
    Post count: 20834

    As mentioned above, I’ve submitted a patch which will contain the above code tweak in the future update.

    #327352
    Pikay
    Member
    Post count: 48

    I do not have $target = "_blank";

    Here is line 325 to 332

    					if ($client_link_url) {
    						if ($client_link_same_window) {
    							$target = "_self";
    						}
    						$items .= '<a href="'.$client_link_url.'" target="_blank"><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';
    					} else {
    						$items .= '<img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" />';
    					}
    

    Do you mean $target = "_self"; to edit?

    #327355
    Pikay
    Member
    Post count: 48

    changing
    target="_blank"
    in line 329 to
    $target = apply_filters('sf_clients_link_target', '_blank');
    causes an error

    #327356
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    Can you provide the description of the error and the entire code of that file?
    Thanks

    -Rui

    #327358
    Pikay
    Member
    Post count: 48

    changing the code in line 329 from
    $items .= '<a href="'.$client_link_url.'" target="_blank"><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';
    to
    $items .= '<a href="'.$client_link_url.'" $target = apply_filters('sf_clients_link_target', '_blank');><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';
    causes

    Parse error: syntax error, unexpected T_STRING in /.../wp-content/themes/dante/swift-framework/page-builder/builder/shortcodes/clients.php on line 329

    ———————————————-

    the entire file /dante/swift-framework/page-builder/builder/shortcodes/clients.php

    <?php
    
    class SwiftPageBuilderShortcode_clients extends SwiftPageBuilderShortcode {
    
        protected function content($atts, $content = null) {
    
    		   	$title = $width = $el_class = $carousel_auto = $output = $tax_terms = $filter = $items = $el_position = '';
    		
    	        extract(shortcode_atts(array(
    	        	'title' => '',
    	        	'item_count'	=> '-1',
    	        	'category'		=> '',
    	        	'carousel' => '',
    	        	'carousel_columns'		=> '',
    	        	'carousel_auto' => 'no',
    	        	'pagination'	=> 'no',
    	        	'el_position' => '',
    	        	'width' => '1/1',
    	        	'el_class' => ''
    	        ), $atts));
    	        
    	        // CATEGORY SLUG MODIFICATION
    	        if ($category == "All") {$category = "all";}
    		    if ($category == "all") {$category = '';}
    		    $category_slug = str_replace('_', '-', $category);
    		    
    		    // CLIENTS QUERY SETUP
        		
        		global $post, $wp_query, $sf_carouselID;
        		
        		if ($sf_carouselID == "") {
        		$sf_carouselID = 1;
        		} else {
        		$sf_carouselID++;
        		}
        		
        		
        		$paged = (get_query_var('paged')) ? get_query_var('paged') : 1;
        		    		
        		$client_args=array(
    	    		'post_type' => 'clients',
    	    		'post_status' => 'publish',
    	    		'paged' => $paged,
    	    		'clients-category' => $category_slug,
    	    		'posts_per_page' => $item_count
           		);
           		    		
        		$clients_items = new WP_Query( $client_args );
        		
        		global $column_width;
        		
        		$item_size_class = "span2";
        		if ($width == "1/4") {
        			$columns = 1;
        			$item_size_class = 'span3';
        		} else if ($width == "1/3") {
        			$columns = 2;
        			$item_size_class = 'span2';
        		} else if ($width == "1/2") {
        			$columns = 3;
        			$item_size_class = 'span2';
        		} else if ($width == "2/3") {
        			$columns = 4;
        			$item_size_class = 'span2';
        		} else if ($width == "3/4") {
        			$columns = 3;
        			$item_size_class = 'span3';
        		} else if ($column_width != "") {
        			if ($column_width == "1/3") {
        			$columns = 2;
        			} else if ($column_width == "1/2") {
        			$columns = 3;
        			} else if ($column_width == "3/4") {
        			$columns = 4;
        			} else {
        			$columns = 6;
        			}	
        		} else {
        			$columns = 6;
        		}
        		
        		$auto = false;
        		
        		if ( $carousel_auto == "yes" ) {
        			$auto = true;
        		}
        		
        		if ($carousel == "yes" || $carousel == "") {    			
        			$items .= '<div class="carousel-wrap">';
        			$items .= '<div id="carousel-'.$sf_carouselID.'" class="clients carousel-items clearfix" data-columns="'.$columns.'" data-auto="'.$auto.'">';
        		} else {
        			$items .= '<div class="carousel-grid row">';
        		}	
        								
    			$client_width = apply_filters('sf_clients_image_width', 200);
    			$client_height = apply_filters('sf_clients_image_height', 200);
    			
    			// CLIENTS LOOP
    			
    			while ( $clients_items->have_posts() ) : $clients_items->the_post();
    			
    				$client_image = get_post_thumbnail_id();
    				$client_img_url = wp_get_attachment_url( $client_image, 'full' );
    				$client_link_url = sf_get_post_meta($post->ID, 'sf_client_link', true);
    				$client_link_same_window = sf_get_post_meta($post->ID, 'sf_client_link_same_window', true);
    				$image_alt = esc_attr( sf_get_post_meta($client_image, '_wp_attachment_image_alt', true) );
    				$target = "_blank";
    				    				
    				$items .= '<div class="clearfix carousel-item client-item '.$item_size_class.'">';
    				    				
    				$items .= '<figure>';
    					
    				$image = sf_aq_resize( $client_img_url, $client_width, $client_height, true, false);
    				
    				if ($image) {
    				
    					if ($client_link_url) {
    					
    					if ($client_link_same_window) {
    						$target = "_self";
    					}
    					
    					$items .= '<a href="'.$client_link_url.'" target="'.$target.'"><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';
    					} else {
    					$items .= '<img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" />';
    					}
    					
    				}
    
    				$items .= '</figure>';
    				
    				$items .= '</div>';
    							
    			endwhile;
    			
    			wp_reset_postdata();
    			
    			if ($carousel == "yes" || $carousel == "") {    			
    				$items .= '</div>';
    				
    				$items .= '<a href="#" class="carousel-prev"><i class="ss-navigateleft"></i></a><a href="#" class="carousel-next"><i class="ss-navigateright"></i></a>';
    				
    				$options = get_option('sf_dante_options');
    				if ($options['enable_swipe_indicators']) {
    				$items .= '<div class="sf-swipe-indicator"></div>';
    				}
    				
    				$items .= '</div>';
    			} else {
    				
    				$items .= '</ul>';
    								
    				// PAGINATION
    				if ($pagination == "yes") {
    				
    					$items .= '<div class="pagination-wrap">';
    					
    					$items .= pagenavi($clients_items);
    										
    					$items .= '</div>';
    				
    				}	
    				
    			}
    			
    			// PAGE BUILDER OUPUT
        		
        		$el_class = $this->getExtraClass($el_class);
                $width = spb_translateColumnWidthToSpan($width);
                
                $output .= "\n\t".'<div class="spb_clients_widget spb_content_element '.$width.$el_class.'">';
                $output .= "\n\t\t".'<div class="spb_wrapper clients-wrap carousel-wrap alt-nav">';
                $output .= ($title != '' ) ? "\n\t\t\t".'<h3 class="spb-heading spb-text-heading"><span>'.$title.'</span></h3>' : '';
                $output .= "\n\t\t\t\t".$items;
                $output .= "\n\t\t".'</div> '.$this->endBlockComment('.spb_wrapper');
                $output .= "\n\t".'</div> '.$this->endBlockComment($width);
        
                $output = $this->startRow($el_position) . $output . $this->endRow($el_position);
               
               	global $sf_include_carousel;
               	$sf_include_carousel = true;
               
                return $output;
    		
        }
    }
    
    SPBMap::map( 'clients', array(
        "name"		=> __("Clients", "swift-framework-admin"),
        "base"		=> "clients",
        "class"		=> "clients",
        "icon"      => "spb-icon-clients",
        "params"	=> array(
        	array(
        	    "type" => "textfield",
        	    "heading" => __("Widget title", "swift-framework-admin"),
        	    "param_name" => "title",
        	    "value" => "",
        	    "description" => __("Heading text. Leave it empty if not needed.", "swift-framework-admin")
        	),
            array(
                "type" => "textfield",
                "class" => "",
                "heading" => __("Number of items", "swift-framework-admin"),
                "param_name" => "item_count",
                "value" => "12",
                "description" => __("The number of clients to show per page. Leave blank to show ALL clients.", "swift-framework-admin")
            ),
            array(
                "type" => "select-multiple",
                "heading" => __("Clients category", "swift-framework-admin"),
                "param_name" => "category",
                "value" => sf_get_category_list('clients-category'),
                "description" => __("Choose the category for the client items.", "swift-framework-admin")
            ),
            array(
                "type" => "dropdown",
                "heading" => __("Carousel", "swift-framework-admin"),
                "param_name" => "carousel",
                "value" => array(__("Yes", "swift-framework-admin") => "yes",
                				__("No", "swift-framework-admin") => "no"
                			),
                "description" => __("Enable the client asset to be a carousel, rather than a grid.", "swift-framework-admin")
            ),
            array(
                "type" => "dropdown",
                "heading" => __("Carousel Auto-Rotate", "swift-framework-admin"),
                "param_name" => "carousel_auto",
                "value" => array(__("Yes", "swift-framework-admin") => "yes",
                				__("No", "swift-framework-admin") => "no"
                			),
                "description" => __("Makes the carousel auto-rotate.", "swift-framework-admin")
            ),
            array(
                "type" => "dropdown",
                "heading" => __("Pagination", "swift-framework-admin"),
                "param_name" => "pagination",
                "value" => array(__('No', "swift-framework-admin") => "no", __('Yes', "swift-framework-admin") => "yes"),
                "description" => __("Show clients pagination.", "swift-framework-admin")
            ),
            array(
                "type" => "textfield",
                "heading" => __("Extra class name", "swift-framework-admin"),
                "param_name" => "el_class",
                "value" => "",
                "description" => __("If you wish to style particular content element differently, then use this field to add a class name and then refer to it in your css file.", "swift-framework-admin")
            )
        )
    ) );
    
    class SwiftPageBuilderShortcode_clients_featured extends SwiftPageBuilderShortcode {
    
        protected function content($atts, $content = null) {
    
    		   	$title = $width = $el_class = $output = $wrap_span = $tax_terms = $filter = $items = $el_position = '';
    		
    	        extract(shortcode_atts(array(
    	        	'title' => '',
    	        	'category'		=> '',
    	        	'alt_background'	=> 'none',
    	        	'el_position' => '',
    	        	'width' => '1/1',
    	        	'el_class' => ''
    	        ), $atts));
    	        
    	        // CATEGORY SLUG MODIFICATION
    	        if ($category == "All") {$category = "all";}
    		    if ($category == "all") {$category = '';}
    		    $category_slug = str_replace('_', '-', $category);
    		    
    		    // CLIENTS QUERY SETUP
        		
        		global $post, $wp_query;
        		
        		$sidebar_config = sf_get_post_meta(get_the_ID(), 'sf_sidebar_config', true);
        		
        		$sidebars = '';
        		if (($sidebar_config == "left-sidebar") || ($sidebar_config == "right-sidebar")) {
        		$wrap_span = "col-sm-6";
        		$sidebars = 'one-sidebar';
        		} else if ($sidebar_config == "both-sidebars") {
        		$wrap_span = "col-sm-4";
        		$sidebars = 'both-sidebars';
        		} else {
        		$wrap_span = "col-sm-10";
        		$sidebars = 'no-sidebars';
        		}
           		    		    		
        		$client_args=array(
    	    		'post_type' => 'clients',
    	    		'post_status' => 'publish',
    	    		'clients-category' => $category_slug,
    	    		'posts_per_page' => 5
           		);
           		    		
        		$clients_items = new WP_Query( $client_args );
        		
        		$items .= '<h4 class="span2">'.$title.'</h4>';
        				
        		$items .= '<div class="featured-clients-items-wrap '.$wrap_span.'">';
    			$items .= '<ul class="featured-clients-items row clearfix">';
    			
    			$client_width = 300;
    			$client_height = NULL;
    			$target = "_blank";
    			
    			// CLIENTS LOOP
    			
    			while ( $clients_items->have_posts() ) : $clients_items->the_post();
    			
    				$client_image = get_post_thumbnail_id();
    				$client_img_url = wp_get_attachment_url( $client_image, 'full' );
    				$client_link_url = sf_get_post_meta($post->ID, 'sf_client_link', true);
    				$image_alt = esc_attr( sf_get_post_meta($client_image, '_wp_attachment_image_alt', true) );
    				    				
    				$items .= '<li class="clearfix span2">';
    				    				
    				$items .= '<figure>';
    					
    				$image = sf_aq_resize( $client_img_url, $client_width, $client_height, true, false);
    				
    				if ($image) {
    				
    					if ($client_link_url) {
    						if ($client_link_same_window) {
    							$target = "_self";
    						}
    						$items .= '<a href="'.$client_link_url.'" target="_blank"><img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" /></a>';
    					} else {
    						$items .= '<img src="'.$image[0].'" width="'.$image[1].'" height="'.$image[2].'" alt="'.$image_alt.'" />';
    					}
    					
    				}
    				
    				$items .= '</figure>';
    							
    			endwhile;
    			
    			wp_reset_postdata();
    					
    			$items .= '</ul></div>';
    			
    			// Full width setup
    			$fullwidth = false;
    			if ($alt_background != "none" && $sidebars == "no-sidebars") {
    			$fullwidth = true;
    			}
    			
    			// PAGE BUILDER OUPUT
        		
        		$el_class = $this->getExtraClass($el_class);
                $width = spb_translateColumnWidthToSpan($width);
                
                $output .= "\n\t".'<div class="spb_featured_clients_widget spb_content_element '.$width.$el_class.'">';
                $output .= "\n\t\t".'<div class="spb_wrapper clients-wrap row">';
                $output .= "\n\t\t\t\t".$items;
                $output .= "\n\t\t".'</div> '.$this->endBlockComment('.spb_wrapper');
                $output .= "\n\t".'</div> '.$this->endBlockComment($width);
        
                $output = $this->startRow($el_position, $width, $fullwidth, "", $alt_background) . $output . $this->endRow($el_position, $width, $fullwidth);
                
                return $output;
    		
        }
    }
    
    SPBMap::map( 'clients_featured', array(
        "name"		=> __("Clients (Featured)", "swift-framework-admin"),
        "base"		=> "clients_featured",
        "class"		=> "clients_featured",
        "icon"      => "spb-icon-clients-featured",
        "params"	=> array(
        	array(
        	    "type" => "textfield",
        	    "heading" => __("Widget title", "swift-framework-admin"),
        	    "param_name" => "title",
        	    "value" => "",
        	    "description" => __("Heading text. Leave it empty if not needed.", "swift-framework-admin")
        	),
            array(
                "type" => "select-multiple",
                "heading" => __("Clients category", "swift-framework-admin"),
                "param_name" => "category",
                "value" => sf_get_category_list('clients-category'),
                "description" => __("Choose the category for the client items.", "swift-framework-admin")
            ),
            array(
                "type" => "dropdown",
                "heading" => __("Show alt background", "swift-framework-admin"),
                "param_name" => "alt_background",
                "value" => array(__("None", "swift-framework-admin") => "none", __("Alt 1", "swift-framework-admin") => "alt-one", __("Alt 2", "swift-framework-admin") => "alt-two", __("Alt 3", "swift-framework-admin") => "alt-three", __("Alt 4", "swift-framework-admin") => "alt-four", __("Alt 5", "swift-framework-admin") => "alt-five", __("Alt 6", "swift-framework-admin") => "alt-six", __("Alt 7", "swift-framework-admin") => "alt-seven", __("Alt 8", "swift-framework-admin") => "alt-eight", __("Alt 9", "swift-framework-admin") => "alt-nine", __("Alt 10", "swift-framework-admin") => "alt-ten"),
                "description" => __("Show an alternative background around the asset. These can all be set in Theme Options > Asset Background Options. NOTE: This is only available on a page with the no sidebar setup.", "swift-framework-admin")
            ),
            array(
                "type" => "altbg_preview",
                "heading" => __("Alt Background Preview", "swift-framework-admin"),
                "param_name" => "altbg_preview",
                "value" => "",
                "description" => ""
            ),
            array(
                "type" => "textfield",
                "heading" => __("Extra class name", "swift-framework-admin"),
                "param_name" => "el_class",
                "value" => "",
                "description" => __("If you wish to style particular content element differently, then use this field to add a class name and then refer to it in your css file.", "swift-framework-admin")
            )
        )
    ) );
    
    ?>
    #327360
    David Martin – Support
    Moderator
    Post count: 20834

    Hi, you are doing it wrong. You will need PHP knowledge to do this. The fix will be in the next update.

    You can either add your FTP details, or I’ll simply send you an update file of for the Page Builder.

    #327362
    Pikay
    Member
    Post count: 48
    This reply has been marked as private.
    #327364
    David Martin – Support
    Moderator
    Post count: 20834

    PS – do you know you can amend this within the client editor:

    Assuming you don’t want to do that and want a global override?

    #327367
    Pikay
    Member
    Post count: 48

    As mentioned in my first post, the check-box has no function 🙁

    #327368
    Pikay
    Member
    Post count: 48

    if it would work with the check-box in the client editor, ist would be fine 🙂

Viewing 15 posts - 1 through 15 (of 22 total)

You must be logged in and have valid license to reply to this topic.

License required for the following item
Login and Registration Log in · Register