Cardinal v1.7 – Mobile menu sub-menu functionality bugs

[FlawlessWeb]

Hey,

I have found another small bug with the mobile menu implementation. This happens when:

#1. You have the admin toolbar on the front end turned on
#2. You have sticky mobile menu enabled

Check my screenshot. On the left hand side you can see a screenshot of the mobile menu when you enable it at the top of the page – i.e. Sticky header is not active.

On the right hand side, you can see a screenshot of the mobile menu when the mobile sticky header is active and you click the menu icon… So as you can see, there is some unnecessary padding above the search box.

I did some testing and turned off the admin toolbar on the front end – the bug is not there in that scenario. So what I think it happening is that the mobile menu adds padding above it to compensate for the admin toolbar. That works fine when the sticky mobile menu is not active. But when the mobile sticky menu is active, the padding remains unnecessarily…

This happens on both desktop and also on mobile browsers.

Hope I explained that ok.

Thanks.

Attachments:

You must be logged in to view attached files.

[Swift Ideas – Ed]

Hi Anthony,

You can adjust it with this custom css:

#mobile-menu-wrap {
padding-top: 0!important;
}

Unfortunately bit tricky to decide as if you remove the padding then the menu will be covered if you scroll to the very top when the admin menu is there.

– Ed

[FlawlessWeb]

Hi Ed,

Yea the css above solves one problem and creates another.

Is there no way to do some kind of if statement to remove the padding if the mobile sticky menu is active?

[Swift Ideas – Ed]

Will add it to the list to try and come up with a solution!

[FlawlessWeb]

Nice one, thanks.

[Kyle – SUPPORT]

No problem

[FlawlessWeb]

Hey Ed,

Any update on resolving the Android menu issues?

Thanks.

[Swift Ideas – Ed]

Should have been resolved in the last update, in terms of clicking the menu button is disabled, so it should only register a single touch.

– Ed

[FlawlessWeb]

Not fixed unfortunately.

The androids bugs which I demonstrated in my video… i.e the pop out/in bugs with both the menu and cart are still there on my sgs4.

[Swift Ideas – Ed]

This reply has been marked as private.

[FlawlessWeb]

Hey,

No it doest unfortunately. Issues with the mobile menu and cart pop outs still there.

[FlawlessWeb]

Just to add to the above, as we talked about in this thread on the 11th of September, the following is still the case:

When I place my finger on the button, either the menu or cart one, and then swipe downwards the functionality is good.

The issue as in my video, arises when you just press the button/s…

Thanks.

[Swift Ideas – Ed]

Hi Anthony,

My hopeful fix was to not trigger the close on the X button touch, as I assumed it was causing two events to be triggered – which I’m not sure is the issue.

Rui is looking into it.

– Ed