New Landing How can we help? Themeforest Theme Support Dante Pagebuilder [spb_row] broken

Viewing 15 posts - 1 through 15 (of 16 total)
  • Posted in: Dante
  • #270234
    adepretis
    Member
    Post count: 12

    Hi,

    since one of the latest updates the PB seems to be broken for the [spb_row] shortcode. When having a simple 1/1 row it looks like this:

    [spb_row width="1/1" el_position="first last"] [/spb_row]

    Then I’ll edit the row and setting e.g. the “Wrap Type” to “Full Width Content” (or ANY other attribute – it doesn’t matter!) it results in:

    [spb_row wrap_type="full-width" row_bg_type="color" color_row_height="content-height" bg_type="cover" parallax_image_height="content-height" parallax_image_movement="fixed" parallax_image_speed="0.5" parallax_video_height="window-height" parallax_video_overlay="none" row_overlay_opacity="0" row_padding_vertical="0" row_padding_horizontal="0" row_margin_vertical="0" remove_element_spacing="no" inner_column_height="col-natural" width="1/1" el_position="first last"] [/spb_row]

    Unfortunately the following happens:

    Variant 1) when switching from SPB to Classic and BACK to SBP all the attributes are gone and only the plain spb_row with el_position attribute is there … this happens ANYTIME you switch from SPB to Classic and back again

    Variant 2) the same thing happens AFTER saving the page WITHOUT switching to Classic! As soon as the SPB is loaded again (which happens when saving) all the attributes vanish and I end up with the basic spb_row with el_position and nothing more.

    This is EXTREMELY bad because you just have to open an existing page and save it again to completely destroy any specially configured sbp_rows.

    It looks to me as if the SPB JavaScript code thinks that all the precious shortcode attributes like wrap_type, row_bg_type, bg_type, height, parallax_image_movement, and so on are invalid shortcode attributes and just strips them.

    Please, please, please help!

    Attachments:
    You must be logged in to view attached files.
    #270667
    David Martin – Support
    Moderator
    Post count: 20834

    Please add a WP login and URL for us.

    Please also setup a test page where we can safely see this happening.

    Thanks.

    #270700
    adepretis
    Member
    Post count: 12

    The problem seems to be in swift-framework/page-builder/builder/lib/shortcodes.php … when I copy the file from an old Dante version 3.11 to the current version 3.3.1 it all works again.

    I guess it’s because of the param-changes – you can find a diff from 3.11 vs. 3.3.1 on https://gist.github.com/adepretis/2f148bf622cec34ceece0ff884184ce8

    The same change has been done in swift-framework/page-builder/builder/shortcodes/accordion.php, tabs.php and tour.php and might result in the same error – as we are not using these I can’t tell.

    #270734
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    @adepretis

    Can you check what Php version is your server running?
    Those changes are related to the PhP 7 compatibility.

    -Rui

    #271034
    adepretis
    Member
    Post count: 12

    Sorry, my bad – my tests where too superficial. The problem described went away but with it all the content within/between the shortcodes too. The change/rollback to the old shortcodes.php results in a page just full of shortcodes, nothing else (although with attributes and everything).

    I debugged it so far: the hidden fields storing the attributes values are empty after switching back to PB from Classic or loading the page with PB activated (see screenshots).

    We are running PHP 7 btw. (this might explain why the content is gone after rolling back to a PHP 7 incompatible code)

    Attachments:
    You must be logged in to view attached files.
    #271038
    adepretis
    Member
    Post count: 12
    This reply has been marked as private.
    #271214
    adepretis
    Member
    Post count: 12
    This reply has been marked as private.
    #271548
    adepretis
    Member
    Post count: 12
    This reply has been marked as private.
    #271957
    adepretis
    Member
    Post count: 12

    Any update? – this issue is really hurting our business!

    #271974
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    Apologize for the delay but also your replies keep pushing the topic to the end of the list.
    The user credentials don’t have admin profile, I need it to check everything.

    -Rui

    #272060
    adepretis
    Member
    Post count: 12

    Hi Rui,

    now the user has admin-rights.

    #272298
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    ok. will check.

    -Rui

    #272307
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    Hi,

    definitely it’s an issue with the Php 7 version. I manage to replicate this in my Php 7 dev server.
    Will check with the development team a solution for this.

    -Rui

    #272365
    Rui Guerreiro – SUPPORT
    Keymaster
    Post count: 25779

    Hi,

    Can you replace your row.php located at dante/swift-framework/page-builder/builder/shortcodes/ by this file below.

    https://www.dropbox.com/s/qvbz6nru1flhbb3/row.php?dl=0

    After replacing the file, you need to clear the cache so this can take effect.

    Let me know if it worked fine.

    -Rui

    #272643
    adepretis
    Member
    Post count: 12

    that worked great – thank you!

Viewing 15 posts - 1 through 15 (of 16 total)

You must be logged in and have valid license to reply to this topic.

License required for one of the following items
Login and Registration Log in · Register